Enforce ruff/refurb rules (FURB) #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhamman
reviewed
Oct 18, 2024
pyproject.toml
Outdated
| "FURB140", # TODO: apply this rule | ||
| "PT004", # deprecated | ||
| "PT011", # TODO: apply this rule | ||
| "PT012", # TODO: apply this rule |
There was a problem hiding this comment.
What do you mean exactly? Don't you like the TODO comments, or the disabled rules? I've disabled them because I'm not necessarily happy with the readability of the code after applying FURB118 and FURB140.
Would it be OK to apply the rules, show the result, and let reviewers decide whether to keep the rules or disable them (without a TODO comment)?
There was a problem hiding this comment.
I'm just curious if these TODOs are for this PR are a later one.
There was a problem hiding this comment.
Let me apply these rules now, I'm interested in your opinion.
DimitriPapadopoulos
force-pushed
the
FURB
branch
3 times, most recently
from
06af42d to
c1b9760
Compare
FURB110 Replace ternary `if` expression with `or` operator
FURB118 Use `operator.itemgetter(0)` instead of defining a lambda
FURB140 Use `itertools.starmap` instead of the generator
FURB188 Prefer `removesuffix` over conditionally replacing with slice.
DimitriPapadopoulos
force-pushed
the
FURB
branch
from
c1b9760 to
b0f2829
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: